Skip to content

ci: fix lint jobs#300

Merged
skevetter merged 2 commits into
mainfrom
fix-lint-jobs
May 16, 2026
Merged

ci: fix lint jobs#300
skevetter merged 2 commits into
mainfrom
fix-lint-jobs

Conversation

@skevetter

@skevetter skevetter commented May 16, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Chores
    • Consolidated linting checks into a single job, removing redundant workflow configurations.
    • Streamlined CI/CD pipeline by eliminating duplicate workflow files.
    • Updated build job dependencies to reference the consolidated linting process.
    • Enhanced code quality check efficiency with updated configuration settings.

Review Change Stack

@netlify

netlify Bot commented May 16, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for devsydev canceled.

Name Link
🔨 Latest commit bea82e1
🔍 Latest deploy log https://app.netlify.com/projects/devsydev/deploys/6a086bba51ef100008305940

@coderabbitai

coderabbitai Bot commented May 16, 2026 •
edited
Loading

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 810691ae-a18f-48bd-8ae8-fa13ab0e6a10

📥 Commits

Reviewing files that changed from the base of the PR and between b01eae3 and bea82e1.

📒 Files selected for processing (3)
  • .github/workflows/lint.yml
  • .github/workflows/pr-ci.yml
  • .github/workflows/pre-commit.yml
💤 Files with no reviewable changes (2)
  • .github/workflows/lint.yml
  • .github/workflows/pre-commit.yml
📝 Walkthrough

Walkthrough

The pull request consolidates GitHub Actions CI workflows by removing standalone lint.yml and pre-commit.yml files and restructuring job dependencies in pr-ci.yml. The lint-gate job is removed, the lint job is updated to use only-new-issues: true, and the build-cli job dependencies are updated to reference the consolidated jobs.

Changes

CI Workflow Consolidation

Layer / File(s) Summary
Consolidate linting into pr-ci.yml
.github/workflows/pr-ci.yml		 Job renamed from "Pre-commit Gate" to "Pre-commit"; separate lint-gate job is removed and consolidated into lint job with only-new-issues: true enabled; build-cli job dependencies updated from [precommit, lint-gate] to [precommit, lint].
Remove standalone pre-commit workflow
.github/workflows/pre-commit.yml		 Entire workflow file removed, consolidating its pre-commit action checks into the main pr-ci.yml workflow.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • devsy-org/devsy#84: Both PRs modify .github/workflows/pr-ci.yml to restructure how pre-commit and golangci-lint gates are defined and enforced via job names and dependencies.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'ci: fix lint jobs' accurately captures the main changes: consolidating linting workflows and fixing the CI job configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@skevetter
skevetter marked this pull request as ready for review May 16, 2026 14:14
@skevetter
skevetter merged commit 5600251 into main May 16, 2026
89 of 90 checks passed
@skevetter
skevetter deleted the fix-lint-jobs branch May 16, 2026 14:36
@coderabbitai coderabbitai Bot mentioned this pull request May 18, 2026
Merged
@coderabbitai coderabbitai Bot mentioned this pull request Jun 22, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

size/m

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@skevetter